Repository navigation
Conversation
davidrohr
reviewed
Nov 9, 2026
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 4147dbf at 2026-11-09 13:03: Full log here. |
Collaborator
|
ok, sorry, that function is static, I should have tried myself. Can you move the mRec->DumpSettings to the end of InitEventGenerator. |
GPUChainTracking::DumpSettings only writes the calibration objects, the GRP settings.dump is written by GPUReconstruction::DumpSettings, so a dataset produced with --eventGenerator could not be read back.
davidrohr
reviewed
Nov 10, 2026
| mClusterError[i][j]->GetXaxis()->SetTitle("Cluster Error [cm]"); | ||
| } | ||
| } | ||
| mRec->rec()->DumpSettings(dir.c_str()); // the chain's own override does not write settings.dump |
Collaborator
There was a problem hiding this comment.
I think now you can use mRec->DumpSettings(...) directly, this was the point of the change in the first place.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GPUChainTracking::DumpSettings only writes the calibration objects, the
GRP settings.dump is written by GPUReconstruction::DumpSettings, so a
dataset produced with --eventGenerator could not be read back.