Repository navigation
Do not take ownership of CCDB distortion maps in the TPC digitizer - #16082
Merged
Merged
Conversation
This fixes a double ownership of the TPC space-charge maps and prepares sharing them between digitizers. - setUseSCDistortions(SC*) and setSCDistortionsDerivative(SC*) took ownership of objects that the DPL CCDB cache owns and deletes itself when a newer object replaces them. - The Digitizer now owns only the maps it creates itself. - The map members are transient for ROOT I/O. https://its.cern.ch/jira/browse/O2-7309 Co-Authored-By: Claude Opus 5.5 <[email protected]>
sawenzel
requested review from
davidrohr,
shahor02 and
wiechula
as code owners
November 9, 2026 08:43
Collaborator
Author
|
@wiechula : |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a double ownership of the TPC space-charge distortion maps and is a preparation for multithreaded TPC digitization.
The Digitizer took ownership of the maps passed to
setUseSCDistortions(SC*)andsetSCDistortionsDerivative(SC*). These objects belong to the DPL CCDB cache, which deletes the old object itself when a newer one replaces it, so a map update within one process would delete it twice. The Digitizer now owns only maps it creates itself, which also lets several digitizers share one map.Digits, labels and common mode are unchanged (checked on a PbPb timeframe with distortions).
https://its.cern.ch/jira/browse/O2-7309
Assisted by Claude Code.