Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
animationandtransitionshorthands expanded into the wrong longhands. Withanimation: slide 1s, the1sended up inanimation-durationandanimation-delay, andanimation-namewas reset toinitial. As soon as a value had two times, e.g.transition: 1s 2soranimation: slide 1s ease-in 2s infinite alternate both paused, every longhand fell back toinitial.transition: nonewas rejected as a whole.TimeBasedShorthandConverterconsumed the time values with the plainTimeConverterinstead of the slot's converter, so the value wasn't bound to its longhand and got handed to every longhand of the shorthand. The time is now consumed through the converter of its slot, so the first time goes to the duration and the second one to the delay, and the other components keep their value. Additionally, thetransitionshorthand acceptsnoneas property, but only if the list has a single item, as css-transitions-1 says.How to test this PR?
CI should succeed. The following tests cover the expansion and fail on master:
AnimationShorthandSetsEveryLonghandAnimationShorthandWithOneTimeSetsOnlyTheDurationAnimationShorthandGivesKeywordsToTheOtherLonghandsFirstAnimationShorthandListSetsTheLonghandsPerItemCssTransitionShorthandWithOneTimeSetsOnlyTheDurationCssTransitionShorthandAssignsTheSecondTimeToTheDelayCssTransitionShorthandNoneSetsThePropertyToNoneCssTransitionShorthandWithNoneInAListIsInvalidmakes suretransition: none, color 1sstays invalid.