Repository navigation
Conversation
…formatting issues
laeg
requested changes
Nov 3, 2026
laeg
left a comment
Contributor
There was a problem hiding this comment.
some changes that would be great to address please mate!
| | `connection_pool_enabled` (`.enableConnectionPool()`) | Enable/disable HTTP connection pooling (keep enabled). | `true` | | ||
| | Property | Builder method | Purpose | | ||
| |-------------------------------|-------------------------------------|-------------------------------------------------------------------------------------------| | ||
| | `max_open_connections` | `.setMaxConnections()` | Maximum open HTTP connections per server endpoint. Size set from parallelism guidance above.| |
Contributor
There was a problem hiding this comment.
I liked that we had the defaults included previously and a recommendation
Also thinking about the type of folks grabbing this, I think we should include back in a baseline example that folks can copy and paste:
public Client.Builder createBaseClient() {
return new Client.Builder()
.addEndpoint("https://your-host:8443")
.setUsername("default")
.setPassword("secret")
.setMaxConnections(50)
.setConnectionRequestTimeout(5, TimeUnit.SECONDS)
.setKeepAliveTimeout(60, TimeUnit.SECONDS)
.setConnectionReuseStrategy(ConnectionReuseStrategy.FIFO);
}
Contributor
Author
There was a problem hiding this comment.
Returned. This example might be a bit harmful because it sets some extra besides we have other examples further. But I have added a baseline example anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previous Comments
Checklist
Delete items not relevant to your PR:
Note
Low Risk
Changes are documentation-only (no runtime code); risk is limited to possible doc inaccuracies or broken links.
Overview
This PR expands and restructures the Java integration documentation across
integration-client.md,integration-jdbc.md,integration-index.md,integration-ops.md, andclickhouse-docs/client.mdx, withintegration-client.mdas the main focus (structure, section order, and follow-up comment fixes).clickhouse-docs/client.mdxadds a ClickHouse ↔ Java type mapping table (with reader/writer notes for binary formats) and a new Optimization / compression section (native block vs HTTP vs app-precompressed payloads, plus configuration property reference).integration-client.mdis reorganized for consistency: configuration references withClient.Builder/ runtime / per-operation examples, richer Step 1 (client capabilities and lifecycle), default database, connection pool guidance (Cloud vs bursty vs batch patterns), retry policy andServerException.isRetriable(), data types pointers, an Optimization chapter (compression examples, pool, JVM/GC), and updated official doc URLs.integration-jdbc.mdgets a new preface, server/client settings examples, read features (FINAL, sequential consistency), async RowBinary ingest guidance, failure handling (retries, schema mismatch / error 33), and link updates to published docs.integration-index.mdadds development environment guidance (Java versions, local Docker, ClickHouse Cloud) and fixes client doc links.Reviewed by Cursor Bugbot for commit b30fdcf. Bugbot is set up for automated code reviews on this repo. Configure here.