Skip to content

[fixed] Canvas cdu method to not make extra call to setScrollLeft in always truth condition - #118

Closed
ptkach wants to merge 1 commit into
Comcast:masterfrom
ptkach:master
Closed

ptkach wants to merge 1 commit into
Comcast:masterfrom
ptkach:master

Conversation

@ptkach

@ptkach ptkach commented Nov 28, 2015

Copy link
Copy Markdown

if (this._scroll !== {start: 0, end: 0}) is always true and it causes extra call to setScrollLeft which iterates through the columns. And when there're huge amount of columns it hits the performance.

@bakesteve

Copy link
Copy Markdown

rather than removing this check, we need to change this to if (this._scroll !== { scrollTop: 0, scrollLeft: 0 } so we'll make that change
thanks for reporting the bug though. I'll update here when the fix is up

@bakesteve bakesteve closed this Dec 3, 2015
@bakesteve bakesteve mentioned this pull request Dec 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants