Repository navigation
ci: read the API key from a variable and pin the test job to ubuntu-24.04 - #247
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Stream API key is an identifier, yet CI reads it from a repository secret. A secret cannot be read back, so nobody can see which test app CI runs against.
The Python 3.8 and 3.9 test jobs also fail at setup since
ubuntu-latestmoved to Ubuntu 26.04, which has no builds of those two versions.Solution
The workflows read the key from the
STREAM_KEYActions variable. The API secret stays a repository secret.The test job runs on
ubuntu-24.04, the newest image that still has Python 3.8 and 3.9.How to verify
STREAM_KEYrepository secret is deleted.Note
Low Risk
Workflow-only changes; no runtime application code, with the main operational risk being misconfigured repository variables after removing the STREAM_KEY secret.
Overview
CI now sources STREAM_KEY from GitHub Actions variables instead of a repository secret in both the main build workflow and scheduled tests, while STREAM_SECRET remains a secret so the key can be inspected without exposing credentials.
The matrix Test & lint job is pinned to
ubuntu-24.04(with a short comment) so Python 3.8 and 3.9 keep working afterubuntu-latestmoved to an image without those runtimes.Reviewed by Cursor Bugbot for commit bbb9ff0. Bugbot is set up for automated code reviews on this repo. Configure here.