Skip to content

[20.0][MIG] document_page: Migration to 20.0 - #647

Merged
OCA-git-bot merged 106 commits into
OCA:20.0from
ledoent:20.0-mig-document_page
Nov 12, 2026
Merged

OCA-git-bot merged 106 commits into
OCA:20.0from
ledoent:20.0-mig-document_page

Conversation

@dnplkndll

@dnplkndll dnplkndll commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Port of document_page from 19.0 to 20.0. Follows the OCA migration guide.

Depends on #646, so Detect unreleased dependencies is red until that lands.

ir.model.access and ir.rule are both removed in 20.0 — the security file is converted to ir.access by upgrade_code --script 19.4-00-ir-access, with the two global rules becoming rows with an empty group_id.

AI-assisted (Claude Code); every change reviewed, tested, and owned by the author.

Maxime Chambreuil and others added 30 commits September 30, 2026 08:13
* Add dependency to knowledge
* Adding hack in document_page_history to allow calling method that don't exists
* document_page_history don't have _sql attribute
* Filter more fields
* Changed history widget to html.
* Improved views and added followers to pages.
* Updated document_page pot and es translations.
* document_page:^Cissing dependency.
* [MIG] Migration to version 10.0
* [FIX] Comments and CI errors
* [FIX] ValueError: External ID not found in the system: base.menu_base_partner
* [FIX] ValueError: Wrong value for ir.actions.act_window.target: 'inlineview'
* [FIX] Based on @lasley comments
* [FIX] External ID not found in the system: base.group_document_user
Currently translated at 51.9% (28 of 54 strings)

Translation: knowledge-11.0/knowledge-11.0-document_page
Translate-URL: https://translation.odoo-community.org/projects/knowledge-11-0/knowledge-11-0-document_page/fa/
Currently translated at 77.8% (42 of 54 strings)

Translation: knowledge-11.0/knowledge-11.0-document_page
Translate-URL: https://translation.odoo-community.org/projects/knowledge-11-0/knowledge-11-0-document_page/de/
Fixing `Page` parents.
…Add history name field, to name revisions. Modified views to allow setting this field.

[document_page] FIX BUG: UI hanging when editing content. This was due to the api.depends on _compute_diff. Removing it because it's not really necessary since the field is not stored.

[document_page] page_id should be readonly.

Improve active field

[document_page] Update version number

[UPD] Update document_page.pot

[MIG] document_page_multi_company (OCA#188)

* [MIG] document_page_multi_company

Added this feature from the old module directly in document_page
- fix references: report module is now web module

- display_* fields are removed in this version
 * move menus to a higher level.
 * fix categories search view.
 * fix create menu action not being accessible in any way.
 * reorder form view, focusing in the content, not in secondary fields.
Currently translated at 100.0% (92 of 92 strings)

Translation: knowledge-12.0/knowledge-12.0-document_page
Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-document_page/fr/
The document.page content for category is required as in 12.0 but in IHM in 12.0 we can create a category without fill this field.

It's only one fix to retrive the same behaviour but investigation in the field definition and computation will be great
Content field can't be required for first document version
_create_history is needed for dependencies
@dnplkndll

Copy link
Copy Markdown
Contributor Author

**XtremXpert **

@XtremXpert looks good thanks

@dnplkndll
dnplkndll requested a review from XtremXpert October 11, 2026 17:27
adminde added a commit to oros-energy/oca-knowledge that referenced this pull request Oct 15, 2026
Head 76fa868 of ledoent:20.0-mig-document_page, open. The last PR commit
961ecd4 (DO NOT MERGE, pins document_knowledge to the open PR in
test-requirements.txt) is left out because document_knowledge is merged here.

@weinni2000 weinni2000 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yann-logisteme yann-logisteme left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Odoo 20.0 Community with #646: install, categories and pages, history after editing (the history_head fix works), read-only users cannot edit, portal users have no access. 18 tests pass. Once #646 is merged, the "[DO NOT MERGE]" commit can be dropped.

Assisted-by: Claude Opus 5.5

Comment thread document_page/views/document_page.xml Resolved

@bm1-phillip bm1-phillip left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review on Odoo 20.0 Community (nightly 20261110), l10n_de (SKR03), together with #646. We use this module in production on 19.0 for our internal handbook.

The 10 tests pass, no warnings from the module in the log.

Checked with the ORM as different users: a category with pages; editing a page creates a new history entry and history_head points to it; the diff between the revisions is there; the template of the category is proposed for a new page. A user with only "Document Knowledge user" can read but not write, create or delete. An editor can write and create but not delete. Internal users without the group and portal users have no access.

LGTM.

20.0 does not load FontAwesome, so fa-* icons render as a blank box with
nothing in the console. Converted with Odoo's own upgrade_code script
19.5-00-material-symbols-icons; the category kanban needed a manual pass
because the script does not rewrite icon names built inside a t-attf
interpolation.

Assisted-by: Claude Opus 5
@dnplkndll
dnplkndll force-pushed the 20.0-mig-document_page branch from 961ecd4 to 01c8c90 Compare November 11, 2026 13:31
@oca-cla-bot

oca-cla-bot Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

@weinni2000

Copy link
Copy Markdown

Hi @ernestotejeda @natuan9 @jacob88 @sysadminmatmoz @llacroix @jdoutreloux @gborelli, your earlier commits are part of this migration, and the CLA check fails for the following emails:

Could you sign at https://clabot.odoo-community.org/ (or have them added to your company's company CLA)? Thanks!

@sysadminmatmoz

Copy link
Copy Markdown
Member

Done from my part.

@weinni2000

weinni2000 commented Nov 11, 2026 •

Copy link
Copy Markdown

Hi @etobella,

they don't have mail addresses anymore: nor github handles:

@yann-logisteme

Copy link
Copy Markdown

#646 is merged now, so the "[DO NOT MERGE]" pin commit can be dropped. That should turn "Detect unreleased dependencies" green and leave only the CLA check, which was not blocking for #646.

Assisted-by: Claude Fable 5.2

@dnplkndll
dnplkndll force-pushed the 20.0-mig-document_page branch from 01c8c90 to b9f37cb Compare November 12, 2026 12:37
@StefanRijnhart

Copy link
Copy Markdown
Member

/ocabot migration document_page
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 20.0 milestone Nov 12, 2026
@OCA-git-bot

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 20.0-ocabot-merge-pr-647-by-StefanRijnhart-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Nov 12, 2026
1 of 9 tasks
@OCA-git-bot
OCA-git-bot merged commit 95c74f5 into OCA:20.0 Nov 12, 2026
7 of 8 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 0bb03b6. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.