Repository navigation
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
parquet/level_comparison.his only included by Parquet implementation files, but Meson installs it with the public Parquet headers. Renaming it as an internal header makes that boundary explicit and prevents it from being treated as public API.What changes are included in this PR?
level_comparison.htolevel_comparison_internal.h.This addresses #55455 without changing runtime behavior.
Are these changes tested?
git diff --checkpassed.parquet/level_comparison.hinclude or install reference.Are there any user-facing changes?
The header is no longer installed as a public Parquet header. No runtime behavior changes.
Was AI used for this PR?
In accordance with the Arrow AI-generation guidance:
PR code and description written by:
Reviewed before submission by:
Codex was used to inspect the issue, implement the scoped rename, and prepare this description. The complete diff was reviewed in this run, and the validation limits are stated above.
parquet/level_comparison.hinternal #55455