Skip to content

GH-55455: [C++] Make level comparison header internal - #55456

Open
09Catho wants to merge 1 commit into
apache:mainfrom
09Catho:fix/internal-level-comparison-header
Open

09Catho wants to merge 1 commit into
apache:mainfrom
09Catho:fix/internal-level-comparison-header

Conversation

@09Catho

@09Catho 09Catho commented Nov 9, 2026 •

Copy link
Copy Markdown

Rationale for this change

parquet/level_comparison.h is only included by Parquet implementation files, but Meson installs it with the public Parquet headers. Renaming it as an internal header makes that boundary explicit and prevents it from being treated as public API.

What changes are included in this PR?

  • Rename level_comparison.h to level_comparison_internal.h.
  • Update the eight internal include sites.
  • Remove the header from Meson's installed-header list.

This addresses #55455 without changing runtime behavior.

Are these changes tested?

  • git diff --check passed.
  • Repository-wide search found no remaining parquet/level_comparison.h include or install reference.
  • A narrow CMake configure reached Arrow's bundled Boost dependency setup, but could not complete within the local validation window; no C++ build result is claimed.

Are there any user-facing changes?

The header is no longer installed as a public Parquet header. No runtime behavior changes.

Was AI used for this PR?

In accordance with the Arrow AI-generation guidance:

PR code and description written by:

  • Human
  • AI

Reviewed before submission by:

  • Human
  • AI
  • Not reviewed

Codex was used to inspect the issue, implement the scoped rename, and prepare this description. The complete diff was reviewed in this run, and the validation limits are stated above.

Copilot AI balanced review requested due to automatic review settings November 9, 2026 15:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

⚠️ GitHub issue #55455 has been automatically assigned in GitHub to PR creator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants