Repository navigation
does the cluster sort here actually reorder anything? its compare never says one cluster comes first, so the order looks random and which cluster gets split depends on that #14625
Description
does the cluster sort here actually reorder anything? its compare never says one cluster comes first, so the order looks random and which cluster gets split depends on that
Originally posted by @Damans227 in #14000 (comment)
public static LinkedHashMap<Long, List<HostVO>> sortByClusterSize(final Map<Long, List<HostVO>> hostToClusterMap) {
List<Long> keys = new ArrayList<Long>();
keys.addAll(hostToClusterMap.keySet());
Collections.sort(keys, new Comparator<Long>() {
@Override
public int compare(Long o1, Long o2) {
List<HostVO> v1 = hostToClusterMap.get(o1);
List<HostVO> v2 = hostToClusterMap.get(o2);
if (v1 == null) {
return (v2 == null) ? 0 : 1;
}
if (v1.size() < v2.size()) {
return 1;
} else {
return 0;
}
}
});
LinkedHashMap<Long, List<HostVO>> sortedMap = new LinkedHashMap<Long, List<HostVO>>();
for (Long key : keys) {
sortedMap.put(key, hostToClusterMap.get(key));
}
return sortedMap;
}
Activity
github-actions commentedon Nov 9, 2026
Warning
threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.
What happened
The threat detection engine failed to produce results.
Review the workflow run logs for details.
🎯 Triage report
The comparator in
sortByClusterSizereturns 1 or 0 but never a negative value, so it does not define a valid ordering. Host-to-cluster entries are therefore not reliably sorted by cluster size, and which cluster is split depends on the input order. The issue was raised from review of PR #14000.📊 Assessment
🔗 Similar issues
💡 Notes and suggestions
Add this agentic workflow to your repo
To install this agentic workflow, run