Repository navigation
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10271 +/- ##
============================================
+ Coverage 20.75% 20.78% +0.02%
- Complexity 21901 21932 +31
============================================
Files 6496 6496
Lines 591602 591657 +55
Branches 72583 72592 +9
============================================
+ Hits 122814 122968 +154
+ Misses 455456 455344 -112
- Partials 13332 13345 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12217 |
|
@blueorangutan test |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-12192)
|
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 15404 |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15427 |
|
@blueorangutan test |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
@sdodsley did you test this in anyway? We have no access to do a 3rd party test. |
boring-cyborg
Bot
added
component:vxlan
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
@sdodsley @sureshanaparti I marked this for 24 as the conflicts to 22 where too big. Please have a look. |
| @@ -59,3 +59,6 @@ UPDATE `cloud`.`configuration` | |||
| SET value = CONCAT_WS('\n', 'Hello {{username}}!', 'You have requested to reset your password. Please click the following link to reset your password:', '{{{resetLink}}}', 'If you did not request a password reset, please ignore this email.', '', 'Regards,', 'The CloudStack Team') | |||
| WHERE name = 'user.password.reset.mail.template' | |||
| AND value IN (CONCAT_WS('\n', 'Hello {{username}}!', 'You have requested to reset your password. Please click the following link to reset your password:', 'http://{{{resetLink}}}', 'If you did not request a password reset, please ignore this email.', '', 'Regards,', 'The CloudStack Team'), CONCAT_WS('\n', 'Hello {{username}}!', 'You have requested to reset your password. Please click the following link to reset your password:', '{{{domainUrl}}}{{{resetLink}}}', 'If you did not request a password reset, please ignore this email.', '', 'Regards,', 'The CloudStack Team')); | |||
|
|
|||
| -- Update storage_provider_name to FlashArray | |||
| UPDATE cloud.storage_pool SET storage_provider_name = 'FlashArray' WHERE storage_provider_name = 'Flash Array'; | |||
There was a problem hiding this comment.
@sdodsley this change would now go in the latest schema file, that upgrades to 4.24 (as the PR is target-ed for main/4.24). otherwise, rebase and re-target with 4.22 and keep this change in schema file that upgrade to 4.22.2.
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
Hi @sdodsley can you please address the conflicts? |
|
@blueorangutan package |
|
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 19894 |
|
Hi @sdodsley there are some build failures after rebasing to main branch, can you please address? |
Merging main (apache#13061, NVMe-TCP transport) left both the old and the new "serial" declaration in FlashArrayAdapter.getVolumeByAddress, which fails to compile, and dropped the FlashArray rename in the protocol selection branch of AddPrimaryStorage.vue. Keep only main's declaration and restore the rename. Assisted-By: Claude Code claude-fable-5-1
schema-42200to42210.sql was frozen when 4.22.1.0 shipped, so upgrades from any released 4.22.1 or 4.23 would never run the UPDATE and existing 'Flash Array' pools would fail provider lookup. Put it in schema-42300to2400.sql instead. Also revert the unrelated Adobe Flash comment in the vendored jQuery and rename the pt_BR tooltip. Assisted-By: Claude Code claude-fable-5-1
|
@blueorangutan package |
|
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19952 |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
Description
This PR changes incorrect references to the Pure Storage FlashArray in both the actual code and in code comments.
Just wanting to make sure that the array is referenced by it correct, trademarked, name.
No functional changes.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
None
How Has This Been Tested?
N/A
How did you try to break this feature and the system with this change?
N/A