Repository navigation
Add overrides for node-gyp version - #13882
DaanHoogland wants to merge 1 commit into
Conversation
|
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 24.51% |
| Branch coverage | 18.67% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13882 +/- ##
============================================
+ Coverage 20.78% 22.09% +1.30%
Complexity 21928 21928
============================================
Files 6496 6003 -493
Lines 591657 549086 -42571
Branches 72592 64523 -8069
============================================
- Hits 122956 121302 -1654
+ Misses 455356 414669 -40687
+ Partials 13345 13115 -230
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
should fix running with newer node versions
eb5b621 to
ab2a44f
Compare
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
3 open issues
overridesis npm-specific (npm v8.3+). If this repository installs the UI with Yarn or… · New^9.4.1) can change the resolvednode-gypversion over time, which can… · New
Review effort: Lite
| "overrides": { | ||
| "node-gyp": "^9.4.1" | ||
| }, |
| "testEnvironment": "node" | ||
| }, | ||
| "overrides": { | ||
| "node-gyp": "^9.4.1" |
| "overrides": { | ||
| "node-gyp": "^9.4.1" | ||
| }, |
|
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 25.89% |
| Branch coverage | 20.22% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
should fix running with newer node versions
Description
This PR upgrades deep dependencies to gyf, making sure the ui works with newer node versions.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?