Skip to content

CLVM/CLVM_NG: Host HA support, lock retry, lease-based lock holder lookup and template LV cleanup fix - #14450

Draft
Pearl1594 wants to merge 5 commits into
mainfrom
clvm-ha-support
Draft

CLVM/CLVM_NG: Host HA support, lock retry, lease-based lock holder lookup and template LV cleanup fix#14450
Pearl1594 wants to merge 5 commits into
mainfrom
clvm-ha-support

CLVM: move sanlock HA checker and lease reader to kvm.storage.clvm pa…

f53764c
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Nov 9, 2026 in 3m 12s

Quality Gate passed

Issues
42 New issues
0 Accepted issues

Measures
0 Security Hotspots
54.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 283 in server/src/test/java/com/cloud/storage/ClvmPoolManagerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "mock". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzaDL9Hl71vwLuQd&open=AaHAuzaDL9Hl71vwLuQd&pullRequest=14450

Check warning on line 845 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuyz7L9Hl71vwLuQM&open=AaHAuyz7L9Hl71vwLuQM&pullRequest=14450

Check warning on line 354 in server/src/main/java/com/cloud/template/TemplateManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzWYL9Hl71vwLuQb&open=AaHAuzWYL9Hl71vwLuQb&pullRequest=14450

Check warning on line 378 in server/src/main/java/com/cloud/storage/clvm/ClvmPoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Method has 9 parameters, which is greater than 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzSEL9Hl71vwLuQV&open=AaHAuzSEL9Hl71vwLuQV&pullRequest=14450

Check failure on line 362 in server/src/main/java/com/cloud/storage/clvm/ClvmPoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Null is returned but a "Boolean" is expected. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzSEL9Hl71vwLuQY&open=AaHAuzSEL9Hl71vwLuQY&pullRequest=14450

Check warning on line 1244 in server/src/main/java/com/cloud/template/TemplateManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this if-then-else statement by a single return statement. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzWYL9Hl71vwLuQc&open=AaHAuzWYL9Hl71vwLuQc&pullRequest=14450

Check failure on line 217 in engine/storage/volume/src/main/java/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use static access with "org.apache.cloudstack.alert.AlertService" for "AlertType". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuyHFL9Hl71vwLuQE&open=AaHAuyHFL9Hl71vwLuQE&pullRequest=14450

Check warning on line 1454 in server/src/test/java/com/cloud/storage/ClvmPoolManagerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "mock". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFa_-RXdA74Gae3fbB4&open=AaFa_-RXdA74Gae3fbB4&pullRequest=14450

Check warning on line 1537 in server/src/test/java/com/cloud/template/TemplateManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "never". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzeQL9Hl71vwLuQh&open=AaHAuzeQL9Hl71vwLuQh&pullRequest=14450

Check warning on line 1555 in server/src/test/java/com/cloud/template/TemplateManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzeQL9Hl71vwLuQk&open=AaHAuzeQL9Hl71vwLuQk&pullRequest=14450

Check warning on line 588 in server/src/main/java/com/cloud/storage/clvm/ClvmPoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Method has 8 parameters, which is greater than 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzSEL9Hl71vwLuQW&open=AaHAuzSEL9Hl71vwLuQW&pullRequest=14450

Check warning on line 79 in server/src/main/java/com/cloud/storage/clvm/ClvmPoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_hostDetailsDao" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzSEL9Hl71vwLuQR&open=AaHAuzSEL9Hl71vwLuQR&pullRequest=14450

Check warning on line 620 in server/src/main/java/com/cloud/storage/clvm/ClvmPoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to use the more specialised Functional Interface 'LongFunction<T>' 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzSEL9Hl71vwLuQa&open=AaHAuzSEL9Hl71vwLuQa&pullRequest=14450

Check failure on line 94 in server/src/main/java/com/cloud/storage/clvm/ClvmPoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Advanced" 4 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFa_-PpdA74Gae3fbB3&open=AaFa_-PpdA74Gae3fbB3&pullRequest=14450

Check warning on line 1569 in server/src/test/java/com/cloud/template/TemplateManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "never". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzeQL9Hl71vwLuQm&open=AaHAuzeQL9Hl71vwLuQm&pullRequest=14450

Check warning on line 104 in engine/storage/volume/src/main/java/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuyHFL9Hl71vwLuQD&open=AaHAuyHFL9Hl71vwLuQD&pullRequest=14450

Check warning on line 1538 in server/src/test/java/com/cloud/template/TemplateManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzeQL9Hl71vwLuQi&open=AaHAuzeQL9Hl71vwLuQi&pullRequest=14450

Check warning on line 1538 in server/src/test/java/com/cloud/template/TemplateManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "never". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzeQL9Hl71vwLuQj&open=AaHAuzeQL9Hl71vwLuQj&pullRequest=14450

Check warning on line 116 in plugins/hypervisors/kvm/src/test/java/org/apache/cloudstack/kvm/ha/KVMHostActivityCheckerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFa_9-DdA74Gae3fbB0&open=AaFa_9-DdA74Gae3fbB0&pullRequest=14450

Check warning on line 827 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuyz7L9Hl71vwLuQJ&open=AaHAuyz7L9Hl71vwLuQJ&pullRequest=14450

Check warning on line 1569 in server/src/test/java/com/cloud/template/TemplateManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzeQL9Hl71vwLuQl&open=AaHAuzeQL9Hl71vwLuQl&pullRequest=14450

Check warning on line 80 in server/src/main/java/com/cloud/storage/clvm/ClvmPoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzSEL9Hl71vwLuQU&open=AaHAuzSEL9Hl71vwLuQU&pullRequest=14450

Check warning on line 78 in server/src/main/java/com/cloud/storage/clvm/ClvmPoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzSEL9Hl71vwLuQT&open=AaHAuzSEL9Hl71vwLuQT&pullRequest=14450

Check warning on line 1536 in server/src/test/java/com/cloud/template/TemplateManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzeQL9Hl71vwLuQf&open=AaHAuzeQL9Hl71vwLuQf&pullRequest=14450

Check failure on line 366 in server/src/main/java/com/cloud/storage/clvm/ClvmPoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Null is returned but a "Boolean" is expected. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaHAuzSEL9Hl71vwLuQZ&open=AaHAuzSEL9Hl71vwLuQZ&pullRequest=14450
View more details on SonarQubeCloud