Repository navigation
fix: update AngleSharp to 1.10.0 and AngleSharp.Css to 1.4.0 - #1971
Merged
Merged
Conversation
Regenerates the element wrapper snapshots so the generated wrappers implement the new BeforeToggle event. Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the AngleSharp dependency and wrapper compatibility update.
No open issues 🎉
What changed in this PR
Updates bUnit’s AngleSharp dependencies so generated element wrappers implement the interfaces required by AngleSharp 1.10.0, addressing the TypeLoadException reported in #1968.
Changes:
- Upgrades AngleSharp to 1.10.0 and AngleSharp.Css to 1.4.0.
- Refreshes 71 wrapper snapshots with
BeforeToggleevent forwarding and removes the obsoleteSelectedIndexsetter from the select wrapper snapshot. - Documents the dependency updates and compatibility fix in the changelog.
| File | Description |
|---|---|
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlVideoElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlUnorderedListElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlUnknownElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlTrackElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlTitleElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlTimeElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlTextAreaElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlTemplateElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlTableSectionElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlTableRowElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlTableHeaderCellElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlTableElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlTableDataCellElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlTableColumnElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlTableCellElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlTableCaptionElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlStyleElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlSpanElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlSourceElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlSlotElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlSelectElementWrapper.g.verified.cs | Adds BeforeToggle; removes SelectedIndex setter. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlScriptElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlQuoteElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlProgressElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlPreElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlPictureElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlParamElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlParagraphElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlOutputElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlOrderedListElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlOptionsGroupElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlOptionElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlObjectElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlModElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlMeterElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlMetaElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlMenuItemElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlMenuElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlMediaElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlMarqueeElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlMapElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlListItemElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlLinkElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlLegendElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlLabelElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlKeygenElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlInputElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlInlineFrameElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlImageElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlHtmlElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlHrElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlHeadingElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlHeadElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlFormElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlFieldSetElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlEmbedElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlDivElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlDialogElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlDetailsElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlDataListElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlDataElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlCommandElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlCanvasElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlButtonElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlBreakRowElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlBodyElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlBaseElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlAudioElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlAreaElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlAnchorElementWrapper.g.verified.cs | Adds BeforeToggle forwarding snapshot. |
| Directory.Packages.props | Updates both AngleSharp dependency versions. |
| CHANGELOG.md | Records dependency updates and the fix for #1968. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request description
Updates AngleSharp from 1.8.6 to 1.10.0 and AngleSharp.Css from 1.2.0 to 1.4.0.
AngleSharp 1.10.0 adds a
BeforeToggleevent toIGlobalEventHandlers. Wrappers built against 1.8.6 do not implement it, soFindthrew aTypeLoadException. The source generator already emits events, so recompiling against 1.10.0 generates them. The verified generator snapshots are regenerated (71 wrappers gainBeforeToggle;HtmlSelectElementWrapperloses theSelectedIndexsetter that AngleSharp 1.9.0 reverted).Fixes #1968
PR meta checklist
mainbranch for codeor targeted at
stablebranch for documentation that is live on bunit.dev.Code PR specific checklist
Validation (net10.0 only, locally):
dotnet test tests/bunit.tests -c Releasepassed (2279),dotnet test tests/bunit.generators.tests -c Releasepassed (7),dotnet test tests/bunit.web.query.tests -c Releasepassed (100).