Repository navigation
fix(nice): bound intervals crossing zero - #293
Open
awais-ur-rehman wants to merge 1 commit into
Open
awais-ur-rehman wants to merge 1 commit into
awais-ur-rehman wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nice(-1, 5, 1)repeatedly widens its domain until the step overflows, so a histogram with one requested threshold can produce NaN bounds. Use a minimum effective count of two for positive counts below two when the interval crosses zero, allowing the existing rounding loop to converge.Fixes #292. Adds coverage for fractional counts, asymmetric intervals on either side of zero, and histogram bounds.
Breaking Changes
None.
Testing
npm test -- --run— 533 passed, 1 skipped.npm run lintnpm run prepublishOnlyI used Codex to help reproduce the failure, implement the fix, and run the tests.