Repository navigation
Conversation
Owner
|
Interesting. Could you provide a longer explanation please? This changes behavior and API. Needs tests, CHANGELOG, UPGRADING, a fixed build, etc. |
Author
|
Longer explanation is method_missing can hijack constants at a higher level. For example: class MyEnum
include Ruby::Enum
define MY_GOOD_CONST, 'good'
end
MY_HIJACKED_CONST = 'hijacked'.freeze$> MyEnum::MY_GOOD_CONST // good
$> MyEnum::MY_HIJACKED_CONST // hijacked <-- this is badNow it appears that my enum contains the const that is defined outside the Also, using Tests and changelog to follow |
Owner
|
How interesting, thanks! |
Author
|
The real risk is having one of your enums get re-defined somewhere else: class MyEnum
include Ruby::Enum
define MY_GOOD_CONST, 'good'
end
MY_GOOD_CONST = 'bad'.freeze$> MyEnum::MY_GOOD_CONST //bad |
Owner
|
@dmoss18 Can you see ^^^ please, would like to get this merged. |
Owner
|
Bump @dmoss18 |
Collaborator
|
@dmoss18 Will you fix this PR? I'm about to implement this if it's OK from you. |
Owner
|
@laertispappas you should finish it, haven't heard from @dmoss18 for a while |
laertispappas
added a commit
to laertispappas/ruby-enum
that referenced
this pull request
Feb 22, 2017
Define constant with const_set instead of "fetching" them with const_missing. These changes were proposed by @dmoss18 in his initial PR (dblock#11). I also add a spec to support the new feature. I kept const_missing method in order to raise the custom Ruby::Enum::Errors::DuplicateKeyError since it provides a handy way to inform the end user for the exception raised.
laertispappas
added a commit
to laertispappas/ruby-enum
that referenced
this pull request
Feb 22, 2017
Define constant with const_set instead of "fetching" them with const_missing. These changes were proposed by @dmoss18 in his initial PR (dblock#11). I also add a spec to support the new feature. I kept const_missing method in order to raise the custom Ruby::Enum::Errors::DuplicateKeyError since it provides a handy way to inform the end user for the exception raised.
Collaborator
|
I'm gonna close this one since it's being addressed in #16 |
laertispappas
added a commit
to laertispappas/ruby-enum
that referenced
this pull request
Feb 22, 2017
Define constant with const_set instead of "fetching" them with const_missing. These changes were proposed by @dmoss18 in his initial PR (dblock#11). I also add a spec to support the new feature. I kept const_missing method in order to raise the custom Ruby::Enum::Errors::DuplicateKeyError since it provides a handy way to inform the end user for the exception raised.
laertispappas
added a commit
to laertispappas/ruby-enum
that referenced
this pull request
Feb 22, 2017
Define constant with const_set instead of "fetching" them with const_missing. These changes were proposed by @dmoss18 in his initial PR (dblock#11). I also add a spec to support the new feature. I kept const_missing method in order to raise the custom Ruby::Enum::Errors::DuplicateKeyError since it provides a handy way to inform the end user for the exception raised.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.