Repository navigation
Conversation
Safety Analysis (FMEA/DFA) status can now be draft, valid or invalid, following gd_req__saf_attr_status version 2. Draft analyses are not checked for mitigated_by, as the existing check only applies to status == valid. Assisted-by: Anthropic Claude Opus 5.5 (claude-opus-5-5)
PandaeDo
requested review from
AlexanderLanin,
MaximilianSoerenPollak,
a-zw,
dcalavrezo-qorix and
nradakovic
as code owners
November 17, 2026 15:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the new Safety Analysis status
draftfrom eclipse-score/process_description#885.Changes
metamodel.yaml:statusofplat_saf_dfa,feat_saf_dfa,comp_saf_dfa,feat_saf_fmea,comp_saf_fmeanow allows^(draft|valid|invalid)$.tool_req__docs_common_attr_status→ version 3, listsdraft(safety analysis elements only).gd_req__saf_attr_status[version==2]andgd_req__saf_attr_mitigation_issue[version==2].tool_req__docs_saf_attrs_mitigated_by: clarifies that draft needs are not checked. No logic change needed, since themitigated_bygraph check and the valid-only-links-to-valid check only apply tostatus == valid.test_options_common_attrs_status.rst: new positive test fordrafton a safety analysis type; the negative test now usesvalid_inspected.Dependency
The
[version==2]links resolve only after ascore_process_descriptionrelease containing #885 and a bump of thebazel_dephere (currently 2.2.4).Local checks
bazel run //:ide_supportbazel test //src/extensions/score_metamodel:file_based_tests_options :file_based_tests_safety :unit_tests→ passed.venv_docs/bin/python -m pytest -vv src/tests/docs_bzl→ 67 passedRelated: eclipse-score/module_template#253
Assisted-by: Anthropic Claude Opus 5.5 (claude-opus-5-5)
🤖 Generated with Claude Code