Repository navigation
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the ServiceConnectionManager in service_manager.dart to await the server.notifyForVmServiceConnection call instead of running it as an unawaited future. There are no review comments, and I have no feedback to provide.
srawlins
approved these changes
Nov 12, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Await
notifyForVmServiceConnectionwhen opening a VM service connection, so that the server finishes registering the connected app's root in DTD before ExtensionService requests api/serveAvailableExtensions.This ensures that when DevTools is run from the CLI or standalone (without an IDE pre-populating DTD workspace roots), DTD's workspace roots already include the connected app's package root before
ServiceManager.vmServiceOpenedsetsconnectedStateto true and triggers ExtensionService to refresh extensions. Without awaiting this call,api/serveAvailableExtensionscan race ahead ofapi/notifyForVmServiceConnectionand arrive at the server before the app's package root has been added to DTD's workspace roots.