Repository navigation
feat(boto3): Add propagate_traces option - #8244
Merged
Merged
Conversation
Co-Authored-By: Ivana Kellyer <[email protected]>
sentry-junior
Bot
force-pushed
the
ivana/boto3-propagate-traces-option
branch
from
November 11, 2026 13:35
151717d to
8d6000c
Compare
sentry-junior
Bot
changed the base branch from
pablo/boto3-add-sqs/sns-propagation
to
major/3.0
November 11, 2026 13:35
Contributor
Coverage Results 📊✅ 58526 passed | ⏭️ 3067 skipped | Total: 61593 | Pass Rate: 95.02% | Execution Time: 160m 7s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00% (6 of 6 changed executable lines covered; target 80%). Changed files with executable lines (2)
Coverage diff@@ Coverage Diff @@
## master #8244 +/-##
==========================================
+ Coverage 90.24% 90.40% +0.16%
==========================================
Files 203 199 -4
Tracked lines 27125 21715 -5410
Branches 10142 7546 -2596
==========================================
- Hits 24478 19630 -4848
+ Misses 2647 2085 -562
+ Partials 1541 1254 -287Generated by Coverage Action |
sentrivana
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
Boto3Integration(propagate_traces=True). Setting it toFalsestops the integration from changing the request params of AWS calls:Invokeno longer gets trace data inClientContext.SendMessage/SendMessageBatchand SNSPublish/PublishBatchno longer getsentry-trace/baggagemessage attributes, and SQSReceiveMessageno longer appends our names toMessageAttributeNames.The option gates the shared
get_request_paramshook, so it covers every extension that uses it without per-service changes. Spans are still created as before.This is an escape hatch for setups where the added data breaks calls, e.g. a queue or topic whose
MaximumMessageSizeis set below the 256 KiB the #8145 size check assumes, or consumers that reject unknown attributes. The name matchesCeleryIntegration(propagate_traces=...).HTTP
sentry-trace/baggageheaders on AWS requests are not affected. They're also added by the stdlib integration and are already controlled bytrace_propagation_targets.Independent of #8145. The SQS/SNS test cases pass trivially until #8145 is merged, and guard the option after that. Whichever PR merges second needs a small conflict fix at the end of
test_trace_propagation.py, since both append tests there.via @sentrivana.
--
View Session [Sentry]