Repository navigation
Replace unmaintained tokenizer benchmark dependencies - #180
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The performance benchmarks still call the removed encode_fast API, preventing the benchmark target and CI’s all-target build from compiling.
2 open issues
What changed in this PR
Updates the benchmark-only Hugging Face tokenizer dependency to remove unmaintained transitive dependencies, without changing the core BPE library.
Changes:
- Pins
tokenizersto1.0.0-rc.4, removingpasteandnumber_prefixfrom the lockfile. - Adapts tokenizer loading and shared encoding helpers to the read-only pipeline API.
- Adds an offline regression test for pre-tokenizer removal.
| File | Description |
|---|---|
crates/bpe/benchmarks/performance.rs |
Migrates an encoding benchmark to the shared helper. |
crates/bpe/benchmarks/lib.rs |
Adds pipeline loading, encoding helpers, and an offline test. |
crates/bpe/benchmarks/equivalence.rs |
Uses the shared helper for equivalence checks. |
crates/bpe/benchmarks/Cargo.toml |
Updates tokenizer dependencies and feature selection. |
Cargo.lock |
Records the updated dependency graph. |
Review effort: Balanced (auto)
aneubeck
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
tokenizers1.0.0-rc.4, removingpasteandnumber_prefixfrom the lockfile.Validation
cargo check -p bpe-benchmarkscargo test -p bpe-benchmarks --libcargo test -p bpe-benchmarks --test equivalence --no-runhuggingface.co, so please run the benchmarks locally.