Skip to content

♻️ use shared workflow linter - #473

Merged
ianardee merged 3 commits into
mainfrom
betterleaks
Nov 3, 2026
Merged

ianardee merged 3 commits into
mainfrom
betterleaks

Conversation

@ianardee

@ianardee ianardee commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Description

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The history scan can miss secrets introduced by merge resolutions, so a separate directory scan is needed to prevent that coverage gap.

1 open issue
What changed in this PR

This PR makes Betterleaks consistently use Git-history scanning in the reusable static-analysis workflow.

Changes:

  • Explicitly sets Betterleaks to git mode.
  • Documents why checkout retains full Git history.
  • Skips the Betterleaks pre-commit hook when running the remaining static checks.
File Description
.github/​workflows/​_static-analysis.yml Sets Git scan mode, explains full-history checkout, and excludes Betterleaks from the prek run.

Review effort: Balanced

Comment thread .github/workflows/_static-analysis.yml Resolved
@ianardee
ianardee force-pushed the betterleaks branch 2 times, most recently from 774de97 to 1354e73 Compare November 3, 2026 15:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The scan can fail clean PRs on unrelated historical findings, miss secrets introduced by merge commits, and expose credentials in uploaded report metadata.

2 open issues
1 resolved since last review

Review effort: Balanced

Comment thread .github/workflows/_static-analysis.yml Resolved
Comment thread .github/workflows/_static-analysis.yml Resolved
@ianardee ianardee changed the title ♻️ always run betterleaks in git mode ♻️ use shared workflow linter Nov 3, 2026
@ianardee
ianardee merged commit 0fe9211 into main Nov 3, 2026
19 checks passed
@ianardee
ianardee deleted the betterleaks branch November 3, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants