Skip to content

♻️ use shared betterleaks - #474

Merged
ianardee merged 1 commit into
mainfrom
bl
Nov 3, 2026
Merged

ianardee merged 1 commit into
mainfrom
bl

Conversation

@ianardee

@ianardee ianardee commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Description

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Direct pushes to main can reach release creation without secret scanning because the shared scan was removed and its Betterleaks replacement runs only for pull requests.

1 open issue
What changed in this PR

This PR moves pull-request secret scanning from the local static-analysis workflow to the shared Betterleaks workflow.

Changes:

  • Adds a shared Betterleaks job and makes unit tests depend on both scanning and static analysis.
  • Removes the local scanner, report upload, failure check, and full-history checkout configuration.
File Description
.github/​workflows/​pull-request.yml Adds shared Betterleaks scanning as a prerequisite for unit tests.
.github/​workflows/​_static-analysis.yml Removes embedded scanning and documents the separate workflow.

Review effort: Balanced

Comment thread .github/workflows/_static-analysis.yml Resolved
Comment on lines +13 to +14
uses: mindee/mindee-api-ruby/.github/workflows/_static-analysis.yml@main
test-units:
@ianardee
ianardee merged commit f58bb71 into main Nov 3, 2026
32 of 37 checks passed
@ianardee
ianardee deleted the bl branch November 3, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants