Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Direct pushes to main can reach release creation without secret scanning because the shared scan was removed and its Betterleaks replacement runs only for pull requests.
1 open issue
What changed in this PR
This PR moves pull-request secret scanning from the local static-analysis workflow to the shared Betterleaks workflow.
Changes:
- Adds a shared Betterleaks job and makes unit tests depend on both scanning and static analysis.
- Removes the local scanner, report upload, failure check, and full-history checkout configuration.
| File | Description |
|---|---|
.github/workflows/pull-request.yml |
Adds shared Betterleaks scanning as a prerequisite for unit tests. |
.github/workflows/_static-analysis.yml |
Removes embedded scanning and documents the separate workflow. |
Review effort: Balanced
Comment on lines
+13
to
+14
| uses: mindee/mindee-api-ruby/.github/workflows/_static-analysis.yml@main | ||
| test-units: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Types of changes