Repository navigation
fix: retry wrapped transaction-not-found errors - #1335
Open
pengbanban wants to merge 1 commit into
Open
pengbanban wants to merge 1 commit into
pengbanban wants to merge 1 commit into
Conversation
Signed-off-by: pengbanban <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A client that wraps
ethereum.NotFoundcausesWaitForTransactionWithContextto return immediately: the current code compares the full error text with"not found".Use
errors.Isto recognize the sentinel through wrapping. The regression returns a wrapped not-found error with a cancelled context and verifies that the wait follows its cancellation path instead of returning the wrapped lookup error.go test ./bindings/utils -count=1passes. No live-chain transaction was submitted.