Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
remlength intext-indentorword-spacing, e.g.<p style="text-indent: 2rem">, throws anInvalidOperationExceptionwhile the styles are applied, and as such the whole document fails to load. Both properties convertemto pixels in their setter viaNoEms, andCssLengthonly looks at the last two characters of the value, so2remends up as anemlength with a parse error, whichConvertEmToPixelsthen refuses. The fix skips the conversion for lengths that didn't parse, same asfont-sizealready does.Note that
remstill resolves to 0 here, like it does formargin,paddingand the other lengths. Resolving it against the root element's font size is a separate change.How to test this PR?
CI should succeed.
TextPropertyTests.RemLengthDoesNotFailTheDocumentcoverstext-indentandword-spacingand fails on master.