Skip to content

Fix crash on rem lengths in text-indent and word-spacing #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eXpl0it3r wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix crash on rem lengths in text-indent and word-spacing #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Source/HtmlRenderer/Core/Dom/CssBoxProperties.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1901,7 +1901,8 @@ public double GetEmHeight()
protected string NoEms(string length)
{
var len = new CssLength(length);
if (len.Unit == CssUnit.Ems)
// CssLength reads rem as em with a parse error
if (len.Unit == CssUnit.Ems && !len.HasError)
{
length = len.ConvertEmToPixels(GetEmHeight()).ToString();
}
Expand Down
11 changes: 11 additions & 0 deletions Source/Test/HtmlRenderer.Test/Css/TextPropertyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using HtmlRenderer.Test.CssEngineSupport;
using HtmlRenderer.Test.TestSupport;
using TheArtOfDev.HtmlRenderer.Core.CssEngine;

namespace HtmlRenderer.Test.Css;
Expand Down Expand Up @@ -822,4 +823,14 @@ public void OverflowWrapAlternateNameNoneIllegal()
Assert.IsInstanceOfType<OverflowWrapProperty>(property);
Assert.IsFalse(property.HasValue);
}

[TestMethod]
[DataRow("text-indent")]
[DataRow("word-spacing")]
public void RemLengthDoesNotFailTheDocument(string property)
{
var (root, _) = LayoutHarness.Layout(LayoutHarness.Wrap($"<p id=x style='{property}: 2rem'>a b</p>"));

Assert.IsNotNull(LayoutHarness.FindById(root, "x"));
}
}
Loading