Skip to content

Review proposals for the shadcn admin UI - #3

Merged
camilleislasse merged 27 commits into
rem42:feat/shadcn-admin-uifrom
camilleislasse:shadcn-admin-ui-review
Nov 16, 2026
Merged

camilleislasse merged 27 commits into
rem42:feat/shadcn-admin-uifrom
camilleislasse:shadcn-admin-ui-review

Conversation

@camilleislasse

Copy link
Copy Markdown

These are proposals from my review of Sylius#403. @rem42 , @loic425 I'd like both your opinions before they land, that's why I didn't commit directly on the branch. One commit per change, so you can keep or drop each one. Tested in the demo with both themes, tests and ECS pass.

Demo:

  • dashboard, book "Export" button and book page stayed in Bootstrap in shadcn mode, they now have shadcn versions in templates/shadcn/ (0efca11)
  • dashboard chart had no colors in shadcn (1231aa6)
  • switching back to Bootstrap gave a 500 because of the stale cache (865c825)

Kit components instead of copied classes (22 templates copied them, the doc listed 4):

  • Alert for flash messages, form error alert and login error (375c0de, 3f13158, 36474c4)
  • Breadcrumb (f7066af), Avatar (3abb848), Sidebar:Input for the menu search (a802ddc)
  • Card + Table for the grid table (0eb19f7), Button for the filter buttons (39d9152)
  • Card + Collapsible for the accordion (fc15e86), DropdownMenu for the dropdown macros (3e01398)

The remaining copies are on purpose, components.md lists them with the reason (bdc120c). Small visual differences: avatar border and initials size, accordion text in 14px, flash spacing, table header row on hover. Note that dropdown.item() now only takes an array of attributes, not a 'data-x=y' string (nothing used that).

Fixes:

  • copy button classes were escaped twice, the icon was 22px instead of 12 (9cdb835)
  • apply_transition: only a few class values were mapped, warning, info... fell back to ghost and success was grey. The icon now uses the palette color (4806106)
  • dropdown.list() lost the item class (3e01398)
  • accordion(): auto_close was ignored, no aria-controls, and in nested accordions opening the outer item rotated the inner chevrons. A small admin--accordion controller keeps one item open (986ec2d). I tried the kit Accordion recipe first but it clips the content, a dropdown in a panel gets cut.
  • Sidebar/GroupLabel was older than UX Toolkit 3.7.1, resynced with app:shadcn:update (2b5adc1)
  • row "…" menu didn't open with Enter or Space (c8e6ec0)

Docs and tests:

  • ShadcnAdminUi tab in the cookbook recipes that had Bootstrap HTML (e74b23f)
  • kit changes table in components.md updated for 3.7 (95f3ccf)
  • migration.md: missing hook changes (30df904) and how to replace the Bootstrap JS, data-bs-* stops working silently (b726a02)
  • neutral branding example in configuration.md (3d21623)
  • copy components tests ported from Bootstrap (e343a2d), plus tests for breadcrumbs, avatar, dropdown and accordion

@rem42 rem42 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work and all fixes, docs & tests it's perfect !

@camilleislasse
camilleislasse merged commit db13b59 into rem42:feat/shadcn-admin-ui Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants