Repository navigation
Review proposals for the shadcn admin UI - #3
Merged
camilleislasse merged 27 commits intoNov 16, 2026
Merged
camilleislasse merged 27 commits into
camilleislasse merged 27 commits into
Conversation
…lapsible components
…wnMenu components
… trigger to its panel
rem42
approved these changes
Nov 15, 2026
rem42
left a comment
Owner
There was a problem hiding this comment.
Thanks for your work and all fixes, docs & tests it's perfect !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are proposals from my review of Sylius#403. @rem42 , @loic425 I'd like both your opinions before they land, that's why I didn't commit directly on the branch. One commit per change, so you can keep or drop each one. Tested in the demo with both themes, tests and ECS pass.
Demo:
templates/shadcn/(0efca11)Kit components instead of copied classes (22 templates copied them, the doc listed 4):
Alertfor flash messages, form error alert and login error (375c0de, 3f13158, 36474c4)Breadcrumb(f7066af),Avatar(3abb848),Sidebar:Inputfor the menu search (a802ddc)Card+Tablefor the grid table (0eb19f7),Buttonfor the filter buttons (39d9152)Card+Collapsiblefor the accordion (fc15e86),DropdownMenufor the dropdown macros (3e01398)The remaining copies are on purpose,
components.mdlists them with the reason (bdc120c). Small visual differences: avatar border and initials size, accordion text in 14px, flash spacing, table header row on hover. Note thatdropdown.item()now only takes an array of attributes, not a'data-x=y'string (nothing used that).Fixes:
apply_transition: only a fewclassvalues were mapped,warning,info... fell back to ghost andsuccesswas grey. The icon now uses the palette color (4806106)dropdown.list()lost the itemclass(3e01398)accordion():auto_closewas ignored, noaria-controls, and in nested accordions opening the outer item rotated the inner chevrons. A smalladmin--accordioncontroller keeps one item open (986ec2d). I tried the kitAccordionrecipe first but it clips the content, a dropdown in a panel gets cut.Sidebar/GroupLabelwas older than UX Toolkit 3.7.1, resynced withapp:shadcn:update(2b5adc1)Docs and tests:
components.mdupdated for 3.7 (95f3ccf)migration.md: missing hook changes (30df904) and how to replace the Bootstrap JS,data-bs-*stops working silently (b726a02)configuration.md(3d21623)