Repository navigation
feat: add shadcn admin ui - #403
Merged
Merged
Conversation
…r the recipes update command
loic425
approved these changes
Nov 10, 2026
…lapsible components
…wnMenu components
… trigger to its panel
camilleislasse
left a comment
Contributor
There was a problem hiding this comment.
Thanks @rem42 for this PR! I reviewed it and tested both themes in the demo. I put my proposals in rem42#3, I'd like your opinion and @loic425's.
Things I didn't touch:
- "Admin panel" in
sidebar.phpgoes through|transbut isn't a key, so it's never translated. Maybe asylius.ui.admin_panelkey in UiTranslations? - Row "…" menu with the keyboard: focus stays on the trigger, arrows do nothing, and with 2+ actions the second Tab closes the menu. I guess because grid actions aren't
DropdownMenu:Item. dropdown.default()only readstext,iconandclassfrombutton, the other Bootstrap options (disabled,icon_only,size...) are ignored. Not used anywhere in the repo though.- No JS test for the custom Stimulus controllers. Bootstrap has one for its copy-to-clipboard controller (
yarn testin CI), the shadcn copy controller could get the same.
Found along the way, not related to this PR (both themes):
- Update page breadcrumbs: with a custom index route, the item links to the list (
/admin/speakers?id=16) instead of the show page. flashes:app.session|default(null)givesnullwhen the session has flash messages but no attribute (SessionisCountableand only counts attributes), so they're not shown. Edge case, e.g. a page without a logged-in user.- Bootstrap
accordion():auto_close: falsedoes nothing,false|default(true)istrue. docs/cookbook/admin_panel/logo.mdusessylius_admin.security.login.logo, it should besylius_admin.security.login.page.logo.
Contributor
Author
|
@camilleislasse i create this PR rem42#4 to add the 4 things you suggested, i hope the implementation is ok ? |
Prometee
approved these changes
Nov 16, 2026
Member
|
@rem42 @camilleislasse I've merged this one on a dedicated branch, so we can start using it in our projects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create shadcn admin ui based on bootstrap admin ui.
Screenshots
Login
Dashboard
Grid
Form
Color themes
Interchangeable color themes, enabled in the bundle configuration (plain CSS, no Tailwind rebuild needed):
Base colors:
stone,zinc,slate. Accents:blue,green,orange,rose,violet.No theme (neutral)
[zinc, blue][stone, orange][slate, violet][green][rose]