Skip to content

Feat/shadcn admin UI review - #4

Closed
rem42 wants to merge 4 commits into
feat/shadcn-admin-uifrom
feat/shadcn-admin-ui-review
Closed

rem42 wants to merge 4 commits into
feat/shadcn-admin-uifrom
feat/shadcn-admin-ui-review

Conversation

@rem42

@rem42 rem42 commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Implementation suggested from this comment: Sylius#403 (review)

  • "Admin panel" in sidebar.php goes through |trans but isn't a key, so it's never translated. Maybe a sylius.ui.admin_panel key in UiTranslations? -> 7f61b93
  • Row "…" menu with the keyboard: focus stays on the trigger, arrows do nothing, and with 2+ actions the second Tab closes the menu. I guess because grid actions aren't DropdownMenu:Item. -> 76686f3
  • dropdown.default() only reads text, icon and class from button, the other Bootstrap options (disabled, icon_only, size...) are ignored. Not used anywhere in the repo though. -> 119865c
  • No JS test for the custom Stimulus controllers. Bootstrap has one for its copy-to-clipboard controller (yarn test in CI), the shadcn copy controller could get the same. -> bfffaae

@rem42
rem42 marked this pull request as draft November 16, 2026 15:10
@rem42
rem42 force-pushed the feat/shadcn-admin-ui-review branch from 5821ee6 to bfffaae Compare November 16, 2026 16:14
@rem42
rem42 marked this pull request as ready for review November 16, 2026 16:18
@loic425

loic425 commented Nov 17, 2026

Copy link
Copy Markdown

Hi @rem42 Could you change the base branch to upstream shadcn-admin-ui branch please?

@loic425 loic425 mentioned this pull request Nov 17, 2026
1 of 4 tasks
@loic425

loic425 commented Nov 17, 2026

Copy link
Copy Markdown

I think you will need to create the PR on github again.

@rem42 rem42 closed this Nov 17, 2026
@rem42

rem42 commented Nov 17, 2026

Copy link
Copy Markdown
Owner Author

Work continue in this PR : Sylius#409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants